fix(sql-editor): allow 10k and 50k rows in pivot queries - #108434

This PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes.

Cyclomatic complexity above the limit in changed typescript files (10 for production files, 15 for test files). Warn only: worth simplifying when you next touch these functions.

New Python code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

New TypeScript code duplication introduced by this branch. Fails at 70+ tokens in app code, or 150+ tokens when both copies live in test files. Advisory while the gate proves itself: extract a shared helper instead of copying.

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 68.96 MiB · 🟢 -161 B (-0.0%)

No file changed by more than 1000 B.

_{Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report}

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/layout/navigation-3000/navigationLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/scenes/dashboard/dashboardLogic.tsx stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/lemon-ui/LemonMarkdown/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/RichContentEditor/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/lib/components/CodeSnippet/ stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 src/taxonomy/core-filter-definitions-by-group.json stays out of src/index.tsx + src/scenes/App.tsx + src/scenes/bootApp.ts
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/scenes/session-recordings/player/sessionRecordingPlayerLogic.ts stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

_{Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479}

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

_{Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile}

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 947.67 MiB · 🟢 -2.8 KiB (-0.0%)

All tests passed.

View test results →

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The BI editor now offers all row-limit options for pivot tables. Heatmap configurations retain the selected limit instead of capping it at 1,000. Tests verify generated queries for limits of 100, 1,000, 10,000, and 50,000, and verify that URL restoration and chart-type changes retain the configured limit.

Systems and components

• observed — frontend (service) was modified; 4 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in frontend/src/scenes/data-warehouse/editor/bi/BIEditor.tsx: Removed the PIVOT_TABLE_QUERY_LIMIT import.
• observed — Modified behavior in frontend/src/scenes/data-warehouse/editor/bi/BIEditor.tsx: Removed the chart-type-specific limit options: pivot tables previously showed only limits at or below PIVOT_TABLE_QUERY_LIMIT, while other chart types showed all limits.
• observed — Modified behavior in frontend/src/scenes/data-warehouse/editor/bi/BIEditor.tsx: The row-limit selector now always receives LIMIT_OPTIONS; pivot tables no longer have a restricted option list.
• observed — Modified behavior in frontend/src/scenes/data-warehouse/editor/bi/biEditorTypes.test.ts: The heatmap dimension and chart-settings test now runs for limits 100, 1,000, 10,000, and 50,000, and expects each supplied limit in the generated query. Previously it ran only at 50,000 and expected a query limit of 1,000; the dimension and chart-settings assertions remain.